Issue/76888 #162
Merged
Issue/76888 #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petitphp
requested changes
Nov 22, 2024
Member
petitphp
left a comment
petitphp
left a comment
There was a problem hiding this comment.
Merci pour la PR. J'ai laissé quelques commentaires pour corriger un bug et améliorer le sens du code dans une condition.
Il faudra penser à appliquer les coding standard sur le code PHP aussi.
Contributor
Author
|
Merci @petitphp pour tes retours ! |
Contributor
Author
|
@petitphp le point qui manquait a été ajouté :) désolée pour l'oubli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
76888 - fix errors 10 & 11 - ensures variables are not empty arrays before use